Gamerules: Make sure player is always passed as type 'base_player' via

parameters instead of just 'entity'.
This commit is contained in:
Marco Cawthorne 2020-10-30 11:28:59 +01:00
parent 43dceb7c5a
commit c100554dcc
17 changed files with 43 additions and 50 deletions

View File

@ -270,7 +270,7 @@ CSGameRules::LevelNewParms(void)
}
void
CSGameRules::PlayerConnect(entity pl)
CSGameRules::PlayerConnect(base_player pl)
{
entity a;
bprint(PRINT_HIGH, sprintf("%s connected\n", pl.netname));
@ -291,7 +291,7 @@ CSGameRules::PlayerConnect(entity pl)
}
void
CSGameRules::PlayerDisconnect(entity pl)
CSGameRules::PlayerDisconnect(base_player pl)
{
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -18,8 +18,8 @@
class CSGameRules:CGameRules
{
virtual void(entity) PlayerConnect;
virtual void(entity) PlayerDisconnect;
virtual void(base_player) PlayerConnect;
virtual void(base_player) PlayerDisconnect;
virtual void(base_player) PlayerKill;
virtual void(base_player) PlayerPostFrame;
virtual void(base_player) PlayerDeath;

View File

@ -32,18 +32,22 @@ void StartFrame(void)
void ClientConnect(float csqc_active)
{
g_grMode.PlayerConnect(self);
/* make sure you never change the classname. ever. */
if (self.classname != "player") {
spawnfunc_player();
}
g_grMode.PlayerConnect((base_player)self);
}
void ClientDisconnect(void)
{
g_grMode.PlayerDisconnect(self);
g_grMode.PlayerDisconnect((base_player)self);
}
void ClientKill(void)
{
player pl = (player)self;
g_grMode.PlayerKill(pl);
g_grMode.PlayerKill((base_player)self);
}
void SpectatorThink(void)
@ -61,15 +65,7 @@ void SpectatorDisconnect(void)
void PutClientInServer(void)
{
player pl;
/* make sure you never change the classname. ever. */
if (self.classname != "player") {
spawnfunc_player();
}
pl = (player)self;
g_grMode.PlayerSpawn(pl);
g_grMode.PlayerSpawn((base_player)self);
/* activate all game_playerspawn entities */
for (entity a = world; (a = find(a, ::targetname, "game_playerspawn"));) {
@ -82,14 +78,12 @@ void PutClientInServer(void)
void PlayerPreThink(void)
{
player pl = (player)self;
g_grMode.PlayerPreFrame(pl);
g_grMode.PlayerPreFrame((base_player)self);
}
void PlayerPostThink(void)
{
player pl = (player)self;
g_grMode.PlayerPostFrame(pl);
g_grMode.PlayerPostFrame((base_player)self);
}
void SetNewParms(void)
@ -101,8 +95,7 @@ void SetNewParms(void)
void SetChangeParms(void)
{
iprint("Setting Level-Change Parameters");
player pl = (player)self;
g_grMode.LevelChangeParms(pl);
g_grMode.LevelChangeParms((base_player)self);
}
void SV_RunClientCommand(void)

View File

@ -35,12 +35,12 @@ CGameRules::ConsoleCommand(base_player pl, string cmd)
/* client */
void
CGameRules::PlayerConnect(entity pl)
CGameRules::PlayerConnect(base_player pl)
{
//print("ClientConnect!\n");
}
void
CGameRules::PlayerDisconnect(entity pl)
CGameRules::PlayerDisconnect(base_player pl)
{
//print("ClientDisconnect!\n");
}

View File

@ -29,8 +29,8 @@ class CGameRules
virtual float(base_player,string) ConsoleCommand;
/* client */
virtual void(entity) PlayerConnect;
virtual void(entity) PlayerDisconnect;
virtual void(base_player) PlayerConnect;
virtual void(base_player) PlayerDisconnect;
virtual void(base_player) PlayerKill;
virtual void(base_player) PlayerSpawn;
virtual void(base_player) PlayerPreFrame;

View File

@ -232,7 +232,7 @@ HLGameRules::LevelChangeParms(base_player pp)
}
void
HLGameRules::PlayerConnect(entity pl)
HLGameRules::PlayerConnect(base_player pl)
{
entity a;
bprint(PRINT_HIGH, sprintf("%s connected\n", pl.netname));
@ -253,7 +253,7 @@ HLGameRules::PlayerConnect(entity pl)
}
void
HLGameRules::PlayerDisconnect(entity pl)
HLGameRules::PlayerDisconnect(base_player pl)
{
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -206,7 +206,7 @@ Called whenever a new client connect to the game
=================
*/
int
Plugin_PlayerConnect(entity cl)
Plugin_PlayerConnect(base_player cl)
{
int rval;
int tval;
@ -242,7 +242,7 @@ Called whenever a client leaves the game
=================
*/
int
Plugin_PlayerDisconnect(entity cl)
Plugin_PlayerDisconnect(base_player cl)
{
int rval;
int tval;

View File

@ -23,6 +23,6 @@ void Plugin_Shutdown(void);
void Plugin_InitEnts(void);
int Plugin_RunClientCommand(void);
int Plugin_ParseClientCommand(string);
int Plugin_PlayerConnect(entity);
int Plugin_PlayerDisconnect(entity);
int Plugin_PlayerConnect(base_player);
int Plugin_PlayerDisconnect(base_player);
void Plugin_PlayerObituary(entity, entity, int, int, int);

View File

@ -195,7 +195,7 @@ HLGameRules::LevelChangeParms(base_player pp)
}
void
HLGameRules::PlayerConnect(entity pl)
HLGameRules::PlayerConnect(base_player pl)
{
entity a;
bprint(PRINT_HIGH, sprintf("%s connected\n", pl.netname));
@ -216,7 +216,7 @@ HLGameRules::PlayerConnect(entity pl)
}
void
HLGameRules::PlayerDisconnect(entity pl)
HLGameRules::PlayerDisconnect(base_player pl)
{
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -210,7 +210,7 @@ HLGameRules::PlayerPostFrame(base_player pp)
}
void
HLGameRules::PlayerConnect(entity pl)
HLGameRules::PlayerConnect(base_player pl)
{
entity a;
bprint(PRINT_HIGH, sprintf("%s connected\n", pl.netname));
@ -231,7 +231,7 @@ HLGameRules::PlayerConnect(entity pl)
}
void
HLGameRules::PlayerDisconnect(entity pl)
HLGameRules::PlayerDisconnect(base_player pl)
{
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -333,7 +333,7 @@ SHMultiplayerRules::PlayerPostFrame(base_player pp)
}
void
SHMultiplayerRules::PlayerConnect(entity pl)
SHMultiplayerRules::PlayerConnect(base_player pl)
{
entity a;
bprint(PRINT_HIGH, sprintf("%s connected\n", pl.netname));
@ -354,7 +354,7 @@ SHMultiplayerRules::PlayerConnect(entity pl)
}
void
SHMultiplayerRules::PlayerDisconnect(entity pl)
SHMultiplayerRules::PlayerDisconnect(base_player pl)
{
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -20,8 +20,8 @@ class SHMultiplayerRules:CGameRules
{
/* client */
virtual void(base_player) PlayerSpawn;
virtual void(entity) PlayerConnect;
virtual void(entity) PlayerDisconnect;
virtual void(base_player) PlayerConnect;
virtual void(base_player) PlayerDisconnect;
virtual void(base_player) PlayerKill;
virtual void(base_player) PlayerDeath;
virtual void(base_player) PlayerPostFrame;

View File

@ -128,7 +128,7 @@ TFCGameRules::LevelNewParms(void)
}
void
TFCGameRules::PlayerConnect(entity pl)
TFCGameRules::PlayerConnect(base_player pl)
{
entity a;
bprint(PRINT_HIGH, sprintf("%s connected\n", pl.netname));
@ -149,7 +149,7 @@ TFCGameRules::PlayerConnect(entity pl)
}
void
TFCGameRules::PlayerDisconnect(entity pl)
TFCGameRules::PlayerDisconnect(base_player pl)
{
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -16,8 +16,8 @@
class TFCGameRules:CGameRules
{
virtual void(entity) PlayerConnect;
virtual void(entity) PlayerDisconnect;
virtual void(base_player) PlayerConnect;
virtual void(base_player) PlayerDisconnect;
virtual void(base_player) PlayerPostFrame;
virtual void(base_player) PlayerSpawn;
virtual void(base_player) PlayerKill;

View File

@ -209,7 +209,7 @@ HLGameRules::PlayerPostFrame(base_player pl)
}
void
HLGameRules::PlayerConnect(entity pl)
HLGameRules::PlayerConnect(base_player pl)
{
entity a;
@ -232,7 +232,7 @@ HLGameRules::PlayerConnect(entity pl)
}
void
HLGameRules::PlayerDisconnect(entity pl)
HLGameRules::PlayerDisconnect(base_player pl)
{
if (Plugin_PlayerDisconnect(pl) == FALSE)
bprint(PRINT_HIGH, sprintf("%s disconnected\n", pl.netname));

View File

@ -16,8 +16,8 @@
class HLGameRules:CGameRules
{
virtual void(entity) PlayerConnect;
virtual void(entity) PlayerDisconnect;
virtual void(base_player) PlayerConnect;
virtual void(base_player) PlayerDisconnect;
virtual void(base_player) PlayerKill;
virtual void(base_player) PlayerPostFrame;

View File

@ -91,6 +91,6 @@ void Game_Input(void)
bprint(PRINT_HIGH, "Respawning all map entities...\n");
}
}
self.impulse = 0;
}