Redundancy check for checksums

Theuaredead commented

2023-05-06 15:36:45 -07:00

I assume this isn't in the script.

Make it so once its parsed an archive, it will only check for the remaining missing data so it doesn't need to run through another set of files.

I assume this isn't in the script. Make it so once its parsed an archive, it will only check for the remaining missing data so it doesn't need to run through another set of files.

eukara commented

2023-05-06 15:46:26 -07:00

Owner

Currently it checksums the installers, and then the individual files when assembling the pak0.pak (stopping when it found a perfect match, moving onto the next file in the list).

It will do one final check on the pak0.pak once it's been assembled, and also checksum all loose files (and only THEN pick alternatives from the directory tree, but only if game dirs match)

So we should be doing enough I think, unless I am misunderstanding the issue?

Currently it checksums the installers, and then the individual files when assembling the pak0.pak (stopping when it found a perfect match, moving onto the next file in the list). It will do one final check on the pak0.pak once it's been assembled, and also checksum all loose files (and only THEN pick alternatives from the directory tree, but only if game dirs match) So we should be doing enough I think, unless I am misunderstanding the issue?

eukara self-assigned this 2023-05-06 15:46:58 -07:00

Theuaredead commented

2023-05-06 15:56:55 -07:00

Author

Maybe, but perhaps in a different way?

Basically, the idea I had in mind is that it would check the first archive for all of the files and document all that failed the checksum check. Once it completed the first archive, it would move onto the next archive in the list and only look at the files that failed the check in the previous archive. This makes it so the script wouldn't need to checksum files over and over again.

If the script does this already, then its safe to close this issue as a non-issue.

Maybe, but perhaps in a different way? Basically, the idea I had in mind is that it would check the first archive for all of the files and document all that failed the checksum check. Once it completed the first archive, it would move onto the next archive in the list and only look at the files that failed the check in the previous archive. This makes it so the script wouldn't need to checksum files over and over again. If the script does this already, then its safe to close this issue as a non-issue.

eukara commented

2023-05-06 16:07:59 -07:00

Owner

So once we extracted the archives, you want us to iterate over the end-result of the extraction before we continue. That's fine, but will take a bit longer (and we'll effectively be doing the same checks in the next steps, when we iterate over the pak0.pak files we actually need)

I'd add it as an optional check. Or force it once I add support for Issue #2

So once we extracted the archives, you want us to iterate over the end-result of the extraction before we continue. That's fine, but will take a bit longer (and we'll effectively be doing the same checks in the next steps, when we iterate over the pak0.pak files we actually need) I'd add it as an optional check. Or force it once I add support for Issue #2

Redundancy check for checksums #3