eukara
/
fallout2-ce
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Review partyFixMultipleMembers

This commit is contained in:
Alexander Batalov 2023-05-24 19:16:21 +03:00
parent 6ad88720a2
commit 7f723f45ee
1 changed files with 45 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

104
src/party_member.cc
View File

@ -81,7 +81,7 @@ static int _partyMemberPrepItemSave(Object* object);
static int _partyMemberItemSave(Object* object); static int _partyMemberItemSave(Object* object);
static int _partyMemberItemRecover(STRUCT_519DA8* a1); static int _partyMemberItemRecover(STRUCT_519DA8* a1);
static int _partyMemberClearItemList(); static int _partyMemberClearItemList();
static int _partyFixMultipleMembers(); static int partyFixMultipleMembers();
static int _partyMemberCopyLevelInfo(Object* object, int a2); static int _partyMemberCopyLevelInfo(Object* object, int a2);
// 0x519D9C // 0x519D9C
@ -656,7 +656,7 @@ int _partyMemberRecoverLoad()
_partyStatePrepped = 0; _partyStatePrepped = 0;
if (!_isLoadingGame()) { if (!_isLoadingGame()) {
_partyFixMultipleMembers(); partyFixMultipleMembers();
} }
return 0; return 0;
@ -760,7 +760,7 @@ int partyMembersLoad(File* stream)
} }
} }
_partyFixMultipleMembers(); partyFixMultipleMembers();
for (int index = 1; index < gPartyMemberDescriptionsLength; index++) { for (int index = 1; index < gPartyMemberDescriptionsLength; index++) {
STRU_519DBC* ptr_519DBC = &(_partyMemberLevelUpInfoList[index]); STRU_519DBC* ptr_519DBC = &(_partyMemberLevelUpInfoList[index]);
@ -1197,16 +1197,14 @@ int partyGetBestSkillValue(int skill)
} }
// 0x495620 // 0x495620
static int _partyFixMultipleMembers() static int partyFixMultipleMembers()
{ {
debugPrint("\n\n\n[Party Members]:"); debugPrint("\n\n\n[Party Members]:");
// NOTE: Original code is slightly different (uses two nested loops).
int critterCount = 0; int critterCount = 0;
for (Object* obj = objectFindFirst(); obj != NULL; obj = objectFindNext()) { Object* obj = objectFindFirst();
if (PID_TYPE(obj->pid) == OBJ_TYPE_CRITTER) { while (obj != NULL) {
critterCount++;
}
bool isPartyMember = false; bool isPartyMember = false;
for (int index = 1; index < gPartyMemberDescriptionsLength; index++) { for (int index = 1; index < gPartyMemberDescriptionsLength; index++) {
if (obj->pid == gPartyMemberPids[index]) { if (obj->pid == gPartyMemberPids[index]) {
@ -1215,64 +1213,52 @@ static int _partyFixMultipleMembers()
} }
} }
if (!isPartyMember) { if (isPartyMember) {
continue; debugPrint("\n PM: %s", critterGetName(obj));
}
debugPrint("\n PM: %s", critterGetName(obj)); bool remove = false;
if (obj->sid == -1) {
bool v19 = false; remove = true;
if (obj->sid == -1) { } else {
v19 = true; // NOTE: Uninline.
} else { Object* partyMember = partyMemberFindByPid(obj->pid);
Object* v7 = NULL; if (partyMember != NULL && partyMember != obj) {
for (int i = 0; i < gPartyMembersLength; i++) { if (partyMember->sid == obj->sid) {
if (obj->pid == gPartyMembers[i].object->pid) { obj->sid = -1;
v7 = gPartyMembers[i].object; }
break; remove = true;
} }
} }
if (v7 != NULL && obj != v7) { if (remove) {
if (v7->sid == obj->sid) { // NOTE: Uninline.
obj->sid = -1; if (obj != partyMemberFindByPid(obj->pid)) {
debugPrint("\nDestroying evil critter doppleganger!");
if (obj->sid != -1) {
scriptRemove(obj->sid);
obj->sid = -1;
} else {
if (queueRemoveEventsByType(obj, EVENT_TYPE_SCRIPT) == -1) {
debugPrint("\nERROR Removing Timed Events on FIX remove!!\n");
}
}
_combat_delete_critter(obj);
objectDestroy(obj, NULL);
// Start over.
critterCount = 0;
obj = objectFindFirst();
continue;
} else {
debugPrint("\nError: Attempting to destroy evil critter doppleganger FAILED!");
} }
v19 = true;
} }
} }
if (!v19) { obj = objectFindNext();
continue;
}
Object* v10 = NULL;
for (int i = 0; i < gPartyMembersLength; i++) {
if (obj->pid == gPartyMembers[i].object->pid) {
v10 = gPartyMembers[i].object;
}
}
// TODO: Probably wrong.
if (obj == v10) {
debugPrint("\nError: Attempting to destroy evil critter doppleganger FAILED!");
continue;
}
debugPrint("\nDestroying evil critter doppleganger!");
if (obj->sid != -1) {
scriptRemove(obj->sid);
obj->sid = -1;
} else {
if (queueRemoveEventsByType(obj, EVENT_TYPE_SCRIPT) == -1) {
debugPrint("\nERROR Removing Timed Events on FIX remove!!\n");
}
}
_combat_delete_critter(obj);
_combatai_delete_critter(obj);
objectDestroy(obj, NULL);
} }
for (int index = 0; index < gPartyMembersLength; index++) { for (int index = 0; index < gPartyMembersLength; index++) {