eukara
/
WebSurf
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Low level cache: Squash use of uninitialised value. 

Coverity issue:

CID 1419828:  Memory - corruptions  (UNINIT)
>>>     Using uninitialized value "output_length".
This commit is contained in:
Michael Drake 2020-02-24 15:09:37 +00:00
parent 133e00edbe
commit f840833723
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
content/llcache.c
View File

@ -1364,7 +1364,6 @@ llcache_serialise_metadata(llcache_object *object,
/* SSL certificates */
for (hloop = 0; hloop < cert_chain_depth; hloop++) {
size_t output_length;
nsuerror res;
/* Certificate error code */
@ -1381,7 +1380,7 @@ llcache_serialise_metadata(llcache_object *object,
/* DER certificate data in base64 encoding */
if (object->chain->certs[hloop].der != NULL) {
output_length = datasize;
size_t output_length = datasize;
res = nsu_base64_encode(
object->chain->certs[hloop].der,
object->chain->certs[hloop].der_length,
@ -1397,8 +1396,8 @@ llcache_serialise_metadata(llcache_object *object,
use++; /* allow for null */
if (use > datasize)
goto overflow;
*(op + output_length) = 0;
op += use;
*(op - 1) = 0;
datasize -= use;
}