Add missing unrefs

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
This commit is contained in:
Daniel Silverstone 2019-12-01 17:25:49 +00:00
parent 5063fc838e
commit 92caa16cfc
No known key found for this signature in database
GPG Key ID: C30DF439F2987D74
2 changed files with 8 additions and 0 deletions

View File

@ -592,6 +592,7 @@ bool content_saw_insecure_objects(struct hlcache_handle *h)
&match) == lwc_error_ok &&
(match == true))) {
/* No insecurity to find */
lwc_string_unref(scheme);
return false;
}
@ -600,9 +601,11 @@ bool content_saw_insecure_objects(struct hlcache_handle *h)
&match) == lwc_error_ok)
&& (match == false)) {
/* I did see something insecure -- ME! */
lwc_string_unref(scheme);
return true;
}
lwc_string_unref(scheme);
/* I am supposed to be secure, but was I overridden */
if (urldb_get_cert_permissions(url)) {
/* I was https:// but I was overridden, that's no good */

View File

@ -4671,6 +4671,7 @@ browser_window_page_info_state browser_window_get_page_info_state(
(lwc_string_isequal(scheme, corestring_lwc_resource,
&match) == lwc_error_ok &&
(match == true))) {
lwc_string_unref(scheme);
return PAGE_STATE_INTERNAL;
}
@ -4678,6 +4679,7 @@ browser_window_page_info_state browser_window_get_page_info_state(
if (lwc_string_isequal(scheme, corestring_lwc_file,
&match) == lwc_error_ok &&
match == true) {
lwc_string_unref(scheme);
return PAGE_STATE_LOCAL;
}
@ -4686,9 +4688,12 @@ browser_window_page_info_state browser_window_get_page_info_state(
&match) == lwc_error_ok &&
(match == false))) {
/* Some remote content, not https, therefore insecure */
lwc_string_unref(scheme);
return PAGE_STATE_INSECURE;
}
lwc_string_unref(scheme);
/* Did we have to override this SSL setting? */
if (urldb_get_cert_permissions(bw->current_parameters.url)) {
return PAGE_STATE_SECURE_OVERRIDE;